Skip to content

fixes on some Buttons to make them use localization (issue #241) - #242

Open
ajiteshbankulaa wants to merge 4 commits into
soundscape-community:mainfrom
ajiteshbankulaa:ButtonsToLocalizationStrings
Open

fixes on some Buttons to make them use localization (issue #241)#242
ajiteshbankulaa wants to merge 4 commits into
soundscape-community:mainfrom
ajiteshbankulaa:ButtonsToLocalizationStrings

Conversation

@ajiteshbankulaa

@ajiteshbankulaa ajiteshbankulaa commented Feb 22, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Summary

Addresses issue #241 by fixing a few labels that weren’t using localization. The About page had English-only button titles, and the Bose headset label in the headphones menu also needed a localization key. I also added a new localization key for the YouTube one since one didn’t exist yet.

Changes

  • About page buttons now use localization keys: Privacy Policy, Services Agreement, YouTube Channel
  • Headphones menu: Bose Frames label is now localized and restores Microsoft wording: “Bose Frames Alto or Rondo” (no parentheses)

Testing

Switched app language and verified the updated labels pull from localization keys.
Note: YouTube Channel and Bose Frames will still display in English until translations are added for non-English locales (new keys added in this PR).

Summary by CodeRabbit

  • New Features

    • Added YouTube Channel link in the About section for easy access to community resources

  • Improvements

    • Updated privacy statement label to "Privacy Policy" for clarity
    • Updated Bose Frames device model label to a localized name
    • Removed France-specific accessibility link from About
    • Adjusted settings/about UI layout and view sizing for a more consistent appearance

@coderabbitai

coderabbitai Bot commented Feb 22, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e54f62 and be29dda.

📒 Files selected for processing (2)
  • apps/ios/GuideDogs/Assets/Localization/en-US.lproj/Localizable.strings
  • apps/ios/GuideDogs/Code/Visual UI/View Controllers/Settings/AboutViewController.swift
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/ios/GuideDogs/Assets/Localization/en-US.lproj/Localizable.strings
📝 Walkthrough

Walkthrough

Added and updated localization keys; replaced a hard-coded Bose model name with a localized lookup; refactored About links to use explicit localization keys and removed FR-specific accessibility insertion; adjusted Settings storyboard frame heights, metadata, and removed designables entries.

Changes

Cohort / File(s) Summary
Localization
apps/ios/GuideDogs/Assets/Localization/en-US.lproj/Localizable.strings		 Added settings.about.title.youtube ("YouTube Channel") and devices.Bose.model_name ("Bose Frames Alto or Rondo"). Updated settings.about.title.privacy from "Soundscape Community Privacy Statement" to "Privacy Policy".
Device model localization
apps/ios/GuideDogs/Code/Sensors/Motion/Headphone Motion/BoseFramesMotionManager.swift		 Replaced hard-coded device name with GDLocalizedString("devices.Bose.model_name") for DEVICE_MODEL_NAME.
About links refactor
apps/ios/GuideDogs/Code/Visual UI/View Controllers/Settings/AboutViewController.swift		 Rewrote about-links initialization to use explicit GDLocalizedString keys (e.g., settings.about.title.whats_new, settings.about.title.privacy, settings.about.title.service_agreement, settings.about.title.youtube). Removed the prior FR-specific accessibility conditional entry.
Storyboard layout & metadata
apps/ios/GuideDogs/Code/Visual UI/Views/Settings.storyboard		 Updated storyboard header metadata; reduced multiple scene heights from ~749 to 680 and adjusted nested frames (including WKWebView heights); removed the <designables> section and related design-time metadata.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • RDMurray

Poem

🐰 I hopped through strings both new and true,
A Bose name whispered in localized hue,
About links lined up in tidy rows,
Frames resized where the settings go,
A little rabbit cheers — hooray for new views! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main objective of the PR: converting UI buttons/labels to use localization keys (including Privacy Policy, Services Agreement, YouTube Channel, and Bose Frames model name), and references the associated issue #241.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JJGatchalian

JJGatchalian commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

I think that the French localization shouldn't be added to the English U.S. file. The better way to do it is to get just the English merged, and then you could sign up for Weblate and update the French for both France and Canada. Or if you already know french, please put the French strings into the French localization files. Since I worked on the English and Spanish translation pull request, that may need to be merged before this fix. Probably RD Murray may have a solution.

@ajiteshbankulaa

ajiteshbankulaa commented Feb 24, 2026

Copy link
Copy Markdown
Author

Hi,
I removed the French localization. I had it because originally, it had it there already in the code for some reason. But yea clearly probably something old and leftover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ajiteshbankulaa @JJGatchalian